fa.linux.kernel Google Group

[PATCH 4/4] coredump: shift down_write(mmap_sem) into coredump_wait()

o...@redhat.com (Oleg Nesterov) — Tue, 16 mrt 2010 19:41:20 UT

- move the cprm.mm_flags checks up, before we take mmap_sem
- move down_write(mmap_sem) and ->core_state check from do_coredump()
to coredump_wait()
This simplifies the code and makes the locking symmetrical.
Signed-off-by: Oleg Nesterov <o...@redhat.com>
---
fs/exec.c | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)

[PATCH 3/4] coredump: factor out put_cred() calls

o...@redhat.com (Oleg Nesterov) — Tue, 16 mrt 2010 19:40:54 UT

Given that do_coredump() calls put_cred() on exit path, it is a bit ugly
to do put_cred() + "goto fail" twice, just add the new "fail_creds" label.
Signed-off-by: Oleg Nesterov <o...@redhat.com>
---
fs/exec.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
--- 34-rc1/fs/exec.c~3_CREDS 2010-03-16 18:09:13.000000000 +0100

[PATCH 2/4] coredump: cleanup "ispipe" code

o...@redhat.com (Oleg Nesterov) — Tue, 16 mrt 2010 19:40:34 UT

- kill "int dump_count", argv_split(argcp) accepts argcp == NULL.
- move "int dump_count" under " if (ispipe)" branch, fail_dropcount
can check ispipe.
- move "char **helper_argv" as well, change the code to do argv_free()
right after call_usermodehelper_fns().
- If call_usermodehelper_fns() fails goto close_fail label instead

[PATCH 1/4] coredump: factor out the not-ispipe file checks

o...@redhat.com (Oleg Nesterov) — Tue, 16 mrt 2010 19:40:10 UT

do_coredump() does a lot of file checks after it opens the file or
calls usermode helper. But all of these checks are only needed in
!ispipe case.
Move this code into the "else" branch and kill the ugly repetitive
ispipe checks.
Signed-off-by: Oleg Nesterov <o...@redhat.com>
---
fs/exec.c | 61 ++++++++++++++++++++++++++++++ ------------------------------ -

[PATCH 0/4] do_coredump: cleanups

o...@redhat.com (Oleg Nesterov) — Tue, 16 mrt 2010 19:39:34 UT

And some more, this time in fs/exec.c.
do_coredump() is unreadable and needs cleanups.
Perhaps we should add the new helper which opens the file or pipe...
Oleg.

Re: Will's kernel compilation error

armi...@gentoo.org (Raúl Porcel) — Tue, 16 mrt 2010 19:35:01 UT

Have one.
My error is as follows:
net/built-in.o: In function `svc_auth_unregister':
(.text+0xb822c): relocation truncated to fit: GPREL16 against `.sbss'
net/built-in.o: In function `svc_auth_unregister':
(.text+0xb8268): relocation truncated to fit: GPREL16 against `.sbss'
net/built-in.o: In function `svc_auth_register':

Re: [PATCH v4 05/11] swiotlb: add swiotlb_set_default_size()

bec...@kernel.crashing.org (Becky Bruce) — Tue, 16 mrt 2010 19:31:20 UT

This is an oops in the original patchset - I think it should be fine
to move the swiotlb_init later as Fujita suggests, at least for 32-bit
powerpc. I just booted this on mpc8641 and everything seems OK.
-Becky

Re: RFC: direct MTD support for SquashFS

vitalyw...@gmail.com (Vitaly Wool) — Tue, 16 mrt 2010 19:18:46 UT

Yeah, I'm interested in that as well.
~Vitaly

Re: [PATCH] NFS: Fix RCU warnings in nfs_inode_return_delegation_noreclaim()

paul...@linux.vnet.ibm.com (Paul E. McKenney) — Tue, 16 mrt 2010 19:15:40 UT

So would something like the following work, then?
cred = rcu_dereference_check(delegati on->cred,
delegation->inode == NULL);
Or would some other check condition be more appropriate?
Thanx, Paul

Re: [PATCH] devtmpfs: support !CONFIG_TMPFS

jac...@sunsite.dk (Peter Korsgaard) — Tue, 16 mrt 2010 19:14:20 UT

Hi,
>> config DEVTMPFS
>> bool "Maintain a devtmpfs filesystem to mount at /dev"
>> - depends on HOTPLUG && SHMEM && TMPFS
>> + depends on HOTPLUG
>> help
>> This creates a tmpfs filesystem instance early at bootup.
>> In this filesystem, the kernel driver core maintains device
Greg> With this patch, the Kconfig help text now is incorrect.

Re: [PATCH] r8169: Fix rtl8169_rx_interrupt()

sergey.senozhat...@gmail.com (Sergey Senozhatsky) — Tue, 16 mrt 2010 19:08:41 UT

Not yet. I'm reading rtl8169_rx_interrupt now and rtl8169_schedule_work in case of RxFOVF
grabbed my attention too.

Will try it.
Sergey

Re: [PATCH] devtmpfs: support !CONFIG_TMPFS

g...@kroah.com (Greg KH) — Tue, 16 mrt 2010 19:08:25 UT

With this patch, the Kconfig help text now is incorrect.
Is there a way to explicitly call out in the Kconfig which way devtmpfs
is being created? How about a multiple selection that chooses either
TMPFS or RAMFS, with the default being TMPFS?
So care to redo this so that people can easily determine what is going

Re: [PATCH 1/2] USB: xhci: rename driver to xhci_hcd

g...@kroah.com (Greg KH) — Tue, 16 mrt 2010 19:08:11 UT

This doesn't apply to the 2.6.34-rc1 kernel. Care to redo it so that I
can apply it?
thanks,
greg k-h

Re: aio: compat_ioctl issue?

jmo...@redhat.com (Jeff Moyer) — Tue, 16 mrt 2010 18:52:56 UT

Sorry for taking so long on this. I only tested the case where niovs >
fast_segs, and I missed an obvious thing: I didn't assign the return
pointer to the proper iovec.
So, this patch should get you going.
Cheers,
Jeff
diff --git a/fs/aio.c b/fs/aio.c
index 1cf12b3..5a38805 100644
--- a/fs/aio.c
+++ b/fs/aio.c

Re: [PATCH] Staging: dream: generic_gpio: Use linux instead of asm uaccess.h

chi...@gmail.com (Chihau Chau) — Tue, 16 mrt 2010 18:52:47 UT

No I don't know how to test it in my G1.
2010/3/15 Pavel Machek <pa...@ucw.cz>: